anton-afanasyev marked 2 inline comments as done. anton-afanasyev added inline comments.
================ Comment at: cfe/trunk/lib/CodeGen/BackendUtil.cpp:1426-1431 EmitAssemblyHelper AsmHelper(Diags, HeaderOpts, CGOpts, TOpts, LOpts, M); if (CGOpts.ExperimentalNewPassManager) AsmHelper.EmitAssemblyWithNewPassManager(Action, std::move(OS)); else AsmHelper.EmitAssembly(Action, std::move(OS)); ---------------- lebedev.ri wrote: > This isn't covered by any timer; if you look in `BackendUtil.cpp`, > `EmitAssemblyHelper` actually has `CodeGenerationTime("codegen", "Code > Generation Time")` timer. Thanks, I'm to add it. ================ Comment at: llvm/trunk/lib/IR/LegacyPassManager.cpp:1686 + llvm::TimeTraceScope TimeScope("OptModule", M.getName()); for (Function &F : M) ---------------- lebedev.ri wrote: > I think this may be the wrong place for this. > This includes the entirety of the pipeline, including all of llvm back-end > stuff. Ok, I'm just to delete this line, this block is outputted by `MPPassManager::runOnModule()` as well. This is just a section to see module name rather than to cover proper part of pipeline. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58675/new/ https://reviews.llvm.org/D58675 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits