Szelethus added a comment. The patch looks alright, I won't formally accept because if I knew how these worked, it wouldn't have caused so much pain to so many people :)
In D68172#1686793 <https://reviews.llvm.org/D68172#1686793>, @aaronpuchert wrote: > In D68172#1686772 <https://reviews.llvm.org/D68172#1686772>, @NoQ wrote: > > > +@Szelethus because i'm a bit out-of-the-loop on plugins: i very vaguely > > remember that we decided to put them into tests(?) > > > The plugins were in `test`, but D62445 <https://reviews.llvm.org/D62445> > changed that. Another solution would have been to move them into the > `unittests` directory. But other example plugins are also part of the > ordinary source tree, see for example `llvm/lib/Transforms/Hello`. In fact > this change is based on LLVMHello, which also has `BUILDTREE_ONLY`. I honestly feel bad about these plugins. The first analyzer plugin laid in the `examples/` folder, but I was cautioned against adding more there as we're not really supporting them, but I think all the trouble of moving them wasn't worth it at all for such a negligible "gain". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68172/new/ https://reviews.llvm.org/D68172 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
