MyDeveloperDay added a comment.
As the number of clauses is vast, I think sometimes its worth just putting a
one-line comment in to explain what construct you are matching, just to help
future maintainers
================
Comment at: clang/lib/Format/TokenAnnotator.cpp:1375
+ }
+
// Line.MightBeFunctionDecl can only be true after the parentheses of a
----------------
could this be done using the MatchingParen?
================
Comment at: clang/lib/Format/TokenAnnotator.cpp:2704
+ return Style.PointerAlignment != FormatStyle::PAS_Left;
return true;
}
----------------
are you not testing the volatile case? could you add a comment here as to what
you are actually matching like the lines above
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68072/new/
https://reviews.llvm.org/D68072
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
