NoQ added inline comments.
================
Comment at: clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp:397-398
+ CallDescriptionMap<CheckFn> NonFreeingMemFnMap{
+ {{"alloca", 1}, &MallocChecker::checkAlloca},
+ {{"_alloca", 1}, &MallocChecker::checkAlloca},
+ {{"malloc", 1}, &MallocChecker::checkMalloc},
----------------
Szelethus wrote:
> NoQ wrote:
> > I think `alloca` deserves `CDF_MaybeBuiltin`. This would also probably
> > allow you to remove the second line.
> Actually, `BuiltinFunctionChecker` uses `evalCall` to create an
> `AllocaRegion` for `__builtin_alloca`. I spent an hour when writing this
> patch to track a crash down when I initially made this `CDF_MaybeBuiltin` :)
Oh misery.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68165/new/
https://reviews.llvm.org/D68165
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
