kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land.
LGTM, thanks ================ Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractFunction.cpp:231 + if (const Stmt *S = Child->ASTNode.get<Stmt>()) + if (EnclosingFunc->hasBody() && EnclosingFunc->getBody() == S) + return false; ---------------- I believe it is not possible to have an `EnclosingFunc` without a body at this point. Let's make it an assertion instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68245/new/ https://reviews.llvm.org/D68245 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
