erichkeane added inline comments.
================ Comment at: clang/include/clang/Basic/TargetInfo.h:947 - virtual bool validateOutputSize(StringRef /*Constraint*/, + virtual bool validateOutputSize(const llvm::StringMap<bool> &FeatureMap, + StringRef /*Constraint*/, ---------------- Other Parameter names are commented out (presumably to avoid an unused param warning?). Do we need to do that for this parameter as well? ================ Comment at: clang/lib/Sema/SemaStmtAsm.cpp:240 +void getFunctionFeatureMap(llvm::StringMap<bool> &FeatureMap, + DiagnosticsEngine &Diags, ---------------- First, this ought to be static. Second, since this is basically identical to what we do for CodeGen, I wonder if this needs to just be a member of Sema/ASTContext or something. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68627/new/ https://reviews.llvm.org/D68627 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
