MyDeveloperDay added a comment.
> Btw, I am the author of the CMakeLists snippet quoted by @MyDeveloperDay. > Before that, it was a shell script that didn't run on Windows. Making it part > of the regression test basically eliminated all discussion about code > formatting, but we had to run large-scale reformatting whenever clang-format > changed in some way. It also runs by the polly-* buildbots which I personally > do not like since I don't see code formatting as a reason why a build should > fail. Thank you for your comment, do we have CMake infrastructure (I'm not a CMake expert) to be able to parameterize that snippet and put it somewhere centrally so that others could simply inherit this in their CMakeList.txt like: file( GLOB files ../lib/Format/*.h ../lib/Format/*.cpp ../unittests/*.cpp ../include/clang/Format/*.h) add_clang_format_target(XXX,files) so that they'd get your XXX-check-format and XXX-update-format rules? It might help the proliferation of clang-formatted areas? (and keep them clean) Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68551/new/ https://reviews.llvm.org/D68551 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
