plotfi marked an inline comment as done.
plotfi added a comment.
In D63978#1706420 <https://reviews.llvm.org/D63978#1706420>, @JamesNagurne
wrote:
> Our team maintains a downstream embedded ARM clang distribution and some
> tests from this commit have begun to fail for us.
> For a number of these tests, there was a REQUIRES: x86-registered-target at
> the top, which has now been removed. Specifically, externstatic.c,
> merge-conflict-test.c, object-float.c, and object.c are failing.
>
> object* tests seem to be based on object.cpp, which had the REQUIRES line,
> and externstatic.c also had that line prior to the change.
> I see that @compnerd suggested the removal, but were you certain that these
> tests would work on clang toolchains for which x86 is not a registered target?
>
> For a failure example, here the output of lit for our toolchain. If you can
> make sense of it, I'd appreciate input on how we can fix or work around it:
>
> > <WORKDIR>/arm-llvm/Release/llvm/bin/clang -c -o - -emit-interface-stubs
> <WORKDIR>/llvm-project/clang/test/InterfaceStubs/object.c |
> <WORKDIR>/arm-llvm/Release/llvm/bin/FileCheck -check-prefix=CHECK-TAPI
> <WORKDIR>/llvm-project/clang/test/InterfaceStubs/object.c
> <WORKDIR>/llvm-project/clang/test/InterfaceStubs/object.c:5:16: error:
> CHECK-TAPI: expected string not found in input
> // CHECK-TAPI: data: { Type: Object, Size: 4 }
> ^
> <stdin>:1:1: note: scanning from here
> --- !experimental-ifs-v1
> ^
>
>
> And when run without FileCheck, our raw output:
>
> > <WORKDIR>/arm-llvm/Release/llvm/bin/clang -c -o - -emit-interface-stubs
> <WORKDIR>/llvm-project/clang/test/InterfaceStubs/object.c
> --- !experimental-ifs-v1
> IfsVersion: 1.0
> Triple: thumbv7em-ti-none-eabihf
> ObjectFileFormat: ELF
> Symbols:
> ...
>
I am sorry for this James. I can add back the REQUIRES lines for now and
coordinate with you on making sure your downstream bots are not affected again
if the REQUIRES are removed again.
By chance are your bots accessible publicly?
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63978/new/
https://reviews.llvm.org/D63978
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
