kadircet added inline comments.
================ Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineInline.cpp:226 +llvm::Expected<tooling::Replacements> +renameParameters(const FunctionDecl *Dest, const FunctionDecl *Source) { + const SourceManager &SM = Dest->getASTContext().getSourceManager(); ---------------- kadircet wrote: > ilya-biryukov wrote: > > This does not rename any references to those parameters, right? > > E.g. > > ``` > > template <class T> void foo(T x); > > > > template <class U> void foo(U x) {} > > ``` > > > > would turn into > > ``` > > template <class U> void foo(T x); > > ``` > > right? > yes that's right, just adding a unittest will address this later on moving into D68937, since it got bigger than expected. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66647/new/ https://reviews.llvm.org/D66647 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits