nick marked 2 inline comments as done. nick added inline comments.
================ Comment at: clang-tools-extra/clang-tidy/modernize/DeprecatedIteratorBaseCheck.cpp:218 + // Requires C++. + if (!getLangOpts().CPlusPlus) + return; ---------------- Eugene.Zelenko wrote: > Should it check for C++17 or newer? I do not think so. It is a backward compatible change. The standard never required to inherit iterators from the `std::iterator`, and the standard library itself had not inheriting from `std::iterator` iterators. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69000/new/ https://reviews.llvm.org/D69000 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
