gribozavr added inline comments.

================
Comment at: lib/AST/Decl.cpp:1543
+        Ctx = ID;
+  }
 
----------------
Like you said in a private conversation, yes, support for `ObjCIvarDecl` also 
seems necessary.


================
Comment at: unittests/AST/NamedDeclPrinterTest.cpp:220
+    "property",
+    "Obj::property"));
+}
----------------
I don't think that `Obj::property` is the preferred syntax. `Obj.property`? I'd 
want a review from someone from Apple to confirm.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56924/new/

https://reviews.llvm.org/D56924



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D56924: Sp... Dmitri Gribenko via Phabricator via cfe-commits

Reply via email to