SouraVX marked 4 inline comments as done. SouraVX added a comment. Thanks Adrian for reviewing this! I've addressed your comments. Please have a look. Working on the adding documentation part.
================ Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1624 + case Decl::CXXMethod: + if (Method->isCopyAssignmentOperator() || + Method->isMoveAssignmentOperator()) ---------------- Hi Adrian, is this fine under switch case, or shall I move it outside ?? ================ Comment at: llvm/include/llvm/IR/DebugInfoFlags.def:92 +// May use this Flag in future, when adding support +// for deleted functions +HANDLE_DISP_FLAG((1u << 9), Deleted) ---------------- aprantl wrote: > ? Wanted to add a note, for future support of Defaulted member functions, they can utilize{or overload} this bit. As this Defaulted or Deleted are mutually exclusive. Is this fine ?? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69215/new/ https://reviews.llvm.org/D69215 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits