MyDeveloperDay added a comment.

In D69433#1722463 <https://reviews.llvm.org/D69433#1722463>, @mrexodia wrote:

> I don't really have a say in this, but I was trying to run the python script 
> to generate the rst file and it didn't work. I tried fixing it, but it's 
> definitely very hacky. Perhaps some kind of test can be introduced that runs 
> this python script and checks if it succeeds, so that people are aware that 
> their changes to Format.h break the documentation generation. I also need 
> this to continue with https://reviews.llvm.org/D31635.


I agree, but first let us get them aligned again first, this revision goes some 
way to making that possible.

The remaining item from @mitchell-stellar's change I had an idea that we could 
put comments regarding the enums into a global dictionary of options, then if 
we see the enum used in the struct we could write the documentation out then, 
and then I think we'd be good, but I'd like to work on that change in 
isolation, and I don't want to do that with this one inflight still

Bottom line lets work out how we want to move forward after we are back in 
shape, at present we are out of sync and the script can't be used without 
wiping out previous documentation.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69433/new/

https://reviews.llvm.org/D69433



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to