ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land.
LGTM, many thanks! ================ Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineInline.cpp:293 + // Now try to generate edits for all the refs. + for (auto &Entry : RefLocs) { + const auto *OldDecl = Entry.first; ---------------- NIT: Maybe move declaration of `Replacements` here? To make it closer to the use-site. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68937/new/ https://reviews.llvm.org/D68937 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits