lenary added a comment. This patch is looking much better, thanks for updating it.
Please may you clarify what RISC-V gcc does for `-lgcc`, `-lgcc_s`, `-lgcc_eh`? Is it different to what gcc does on other targets? Being closer to matching the linker arguments that gcc provides to ld seems like a good idea, IMO. In D68407#1732619 <https://reviews.llvm.org/D68407#1732619>, @edward-jones wrote: > In D68407#1709235 <https://reviews.llvm.org/D68407#1709235>, @lenary wrote: > > > Please can you add a test for riscv32 and riscv64 without libgcc? > > > I'm not sure what you mean here; I believe the existing tests already cover > riscv{32,64} without libgcc. I'm not sure what I meant there either, sorry. Do disregard that question CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68407/new/ https://reviews.llvm.org/D68407 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
