jdoerfert marked 2 inline comments as done. jdoerfert added inline comments.
================ Comment at: clang/include/clang/Driver/Options.td:1643 HelpText<"Emit OpenMP code only for SIMD-based constructs.">; +def fopenmp_new_codegen : Flag<["-"], "fopenmp-new-codegen">, Group<f_Group>, Flags<[CC1Option, NoArgumentUnused, HelpHidden]>, + HelpText<"Use the experimental OpenMP-IR-Builder codegen path.">; ---------------- JonChesterfield wrote: > jdoerfert wrote: > > ABataev wrote: > > > Maybe just `-fopenmp-experimental`? > > I would prefer the option to be self explanatory but I'm not married to the > > current name. > `enable-openmpirbuilder?` Sure, I'll change it. ================ Comment at: llvm/include/llvm/IR/OpenMPKinds.def:186 +///{ + +#ifndef OMP_IDENT_FLAG ---------------- JonChesterfield wrote: > Sharing constants between the compiler and the runtime is an interesting > subproblem. I think the cleanest solution is the one used by libc, where the > compiler generates header files containing the constants which the runtime > library includes. I'd prefer not to tackle this right now but get this done first and revisit the issue later. OK? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69785/new/ https://reviews.llvm.org/D69785 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits