cchen marked an inline comment as done. cchen added inline comments.
================ Comment at: clang/lib/Sema/SemaOpenMP.cpp:16393-16416 +static DefaultMapImplicitBehavior +getImplicitBehaviorFromModifier(OpenMPDefaultmapClauseModifier M) { + switch (M) { + case OMPC_DEFAULTMAP_MODIFIER_alloc: + return DMIB_alloc; + case OMPC_DEFAULTMAP_MODIFIER_to: + return DMIB_to; ---------------- ABataev wrote: > ABataev wrote: > > Do we need types `DefaultMapImplicitBehavior` and > > `DefaultMapVariableCategory` if the map 1 to 1 to > > `OpenMPDefaultmapClauseModifier` and `OpenMPDefaultmapClauseKind`? > What about this? The value of OpenMPDefaultmapClauseModifier does not start from one (due to the design in parsing I guess) so I'm not able to do so. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69204/new/ https://reviews.llvm.org/D69204 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits