djasper added a comment.

I am missing a decent explanation here. In contrast to C++ #includes as well as 
goog.require, etc. The import/export statements actually provide syntactic 
structure and can name multiple entities. Why would it be a good idea to always 
write them into a single line?


================
Comment at: unittests/Format/FormatTestJS.cpp:867
@@ -869,11 +866,3 @@
                "} from 'some/module.js';");
-  verifyFormat("import {\n"
-               "  X,\n"
-               "  Y,\n"
-               "} from 'some/module.js';");
-  verifyFormat("import {\n"
-               "  X,\n"
-               "  Y,\n"
-               "} from 'some/long/module.js';",
-               getGoogleJSStyleWithColumns(20));
+  verifyFormat("import {X, Y,} from 'some/module.js';");
   verifyFormat("import {X as myLocalX, Y as myLocalY} from 'some/module.js';");
----------------
Really?


http://reviews.llvm.org/D17440



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to