dcoughlin accepted this revision. dcoughlin added a comment. This revision is now accepted and ready to land.
Looks great, other than some non-standard indentation. ================ Comment at: lib/StaticAnalyzer/Checkers/CStringChecker.cpp:1886 @@ +1885,3 @@ + svalBuilder.evalBinOp(state, op, resultVal, zeroVal, + svalBuilder.getConditionType()); + DefinedSVal compareWithZeroVal = compareWithZero.castAs<DefinedSVal>(); ---------------- Non-standard indentation here. http://reviews.llvm.org/D16317 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
