dblaikie added a comment.

In D70340#1748712 <https://reviews.llvm.org/D70340#1748712>, @thakis wrote:

> I don't see any reason not to do this. What's there to discuss? I'm probably 
> missing something obvious.


Eh, it's a bit quirky - adds production code (albeit a very small amount) only 
to improve debug build properties. I'm not super averse to it - though would 
like @rsmith to weigh in before committing to it.

> dblaikie added anchor functions in many places a while ago (but iirc for 
> vtables, not debug info).

Yeah, that was just following the rules (& a little pedantry/boredom): 
https://llvm.org/docs/CodingStandards.html#provide-a-virtual-method-anchor-for-classes-in-headers
 - it'd be interesting to see how much those are actually worth in object size 
with and without debug info.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70340/new/

https://reviews.llvm.org/D70340



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to