nridge marked an inline comment as done. nridge added inline comments.
================ Comment at: clang-tools-extra/clangd/ParsedAST.h:100 + const std::vector<SourceRange> &getSkippedRanges() const { + return SkippedRanges; ---------------- hokein wrote: > hokein wrote: > > Instead of adding new member and methods in `ParsedAST`, I think we can do > > it in `CollectMainFileMacros` (adding a new field SkippRanges in > > `MainFileMacros`), then we can get the skipped ranges for preamble region > > within the main file for free. > This comment is undone. My apologies, I overlooked this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67536/new/ https://reviews.llvm.org/D67536 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits