Author: Haojian Wu Date: 2019-11-18T15:20:42+01:00 New Revision: b622ff39c0c482494a7400ac0256b543025cd449
URL: https://github.com/llvm/llvm-project/commit/b622ff39c0c482494a7400ac0256b543025cd449 DIFF: https://github.com/llvm/llvm-project/commit/b622ff39c0c482494a7400ac0256b543025cd449.diff LOG: [clangd] Fix some clang-tidy warnings on SourceCodeTests.cpp, NFC. Added: Modified: clang-tools-extra/clangd/unittests/SourceCodeTests.cpp Removed: ################################################################################ diff --git a/clang-tools-extra/clangd/unittests/SourceCodeTests.cpp b/clang-tools-extra/clangd/unittests/SourceCodeTests.cpp index adc09a4f311d..0dabce2a3d64 100644 --- a/clang-tools-extra/clangd/unittests/SourceCodeTests.cpp +++ b/clang-tools-extra/clangd/unittests/SourceCodeTests.cpp @@ -27,7 +27,6 @@ namespace { using llvm::Failed; using llvm::HasValue; -using ::testing::UnorderedElementsAreArray; MATCHER_P2(Pos, Line, Col, "") { return arg.line == int(Line) && arg.character == int(Col); @@ -36,18 +35,18 @@ MATCHER_P2(Pos, Line, Col, "") { MATCHER_P(MacroName, Name, "") { return arg.Name == Name; } /// A helper to make tests easier to read. -Position position(int line, int character) { +Position position(int Line, int Character) { Position Pos; - Pos.line = line; - Pos.character = character; + Pos.line = Line; + Pos.character = Character; return Pos; } -Range range(const std::pair<int, int> p1, const std::pair<int, int> p2) { - Range range; - range.start = position(p1.first, p1.second); - range.end = position(p2.first, p2.second); - return range; +Range range(const std::pair<int, int> &P1, const std::pair<int, int> &P2) { + Range Range; + Range.start = position(P1.first, P1.second); + Range.end = position(P2.first, P2.second); + return Range; } TEST(SourceCodeTests, lspLength) { _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits