aprantl added a comment.
Thanks! Couple of minor comments inline.
================
Comment at: clang/test/CodeGenCXX/debug-info-auto-return.cpp:2
+// Test for debug info for C++11 auto return member functions
+// Supported: -O0, standalone DI
+// RUN: %clang_cc1 -dwarf-version=5 -emit-llvm -triple x86_64-linux-gnu %s -o
- \
----------------
What does this comment mean? This should work regardless of optimization level,
right?
================
Comment at: clang/test/CodeGenCXX/debug-info-auto-return.cpp:8
+
+// CHECK: !DIBasicType(tag: DW_TAG_unspecified_type, name: "auto")
+
----------------
Can you also CHECK that it is attached to the node we're expecting it to?
================
Comment at: llvm/test/DebugInfo/X86/debug-info-auto-return.ll:1
+;RUN: llc %s -filetype=obj -o - | llvm-dwarfdump -v - | FileCheck %s
+
----------------
I think you may need %llc_dwarf here to avoid problems on Windows bots?
================
Comment at: llvm/test/DebugInfo/X86/debug-info-auto-return.ll:110
+
+attributes #0 = { noinline nounwind optnone uwtable
"correctly-rounded-divide-sqrt-fp-math"="false" "disable-tail-calls"="false"
"frame-pointer"="all" "less-precise-fpmad"="false" "min-legal-vector-width"="0"
"no-infs-fp-math"="false" "no-jump-tables"="false" "no-nans-fp-math"="false"
"no-signed-zeros-fp-math"="false" "no-trapping-math"="false"
"stack-protector-buffer-size"="8" "target-cpu"="x86-64"
"target-features"="+cx8,+fxsr,+mmx,+sse,+sse2,+x87" "unsafe-fp-math"="false"
"use-soft-float"="false" }
+attributes #1 = { nounwind readnone speculatable willreturn }
----------------
please remove all unnecessary (quoted) attributes. This makes the test easier
to maintain and read.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70524/new/
https://reviews.llvm.org/D70524
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
