Anastasia added a comment. A few small comments!
================ Comment at: include/clang/Basic/AttrDocs.td:1572 @@ +1571,3 @@ +The __read_only, __write_only, __read_write, read_only, write_only and +read_write names are reserved for use as access qualifiers and shall not be +used otherwise. ---------------- what about __read_write? ================ Comment at: include/clang/Basic/DiagnosticSemaKinds.td:7713 @@ +7712,3 @@ +def err_opencl_invalid_read_write : Error< + "access qualifier read_write can not be used for %0 %select{|earlier than OpenCL2.0 version}1">; +def err_opencl_multiple_access_qualifiers : Error< ---------------- could you write __read_write/read_write please! ================ Comment at: test/SemaOpenCL/invalid-pipe-builtin-cl2.0.cl:24 @@ -23,3 +23,3 @@ work_group_commit_read_pipe(p, tmp); // expected-error{{invalid argument type to function work_group_commit_read_pipe (expecting 'reserve_id_t')}} - sub_group_commit_write_pipe(p, tmp); // expected-error{{nvalid pipe access modifier (expecting write_only)}} } ---------------- This test doesn't seem to work correctly because it didn't detect that we were checking for the wrong error message! I am thinking it might be the issue of adding "-ferror-limit 100" to the RUN line as it might have stopped to diagnose after certain number of errors given. Could you please double check this? http://reviews.llvm.org/D16040 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits