aaron.ballman added a comment. Basically LGTM but I am hoping we can get a better name than `Attr.h` and `Attrs.h`.
================ Comment at: clang/include/clang/AST/Attrs.h:1 +//===--- Attr.h - Classes for representing attributes ----------*- C++ -*-===// +// ---------------- This should read `Attrs.h` instead, but I find the naming distinction to be a bit too subtle. How about `AttrSubclasses.h` or `ConcreteAttrs.h` (other suggestions welcome too). ================ Comment at: clang/include/clang/AST/Attrs.h:13 + +#ifndef LLVM_CLANG_AST_ATTRS_H +#define LLVM_CLANG_AST_ATTRS_H ---------------- Once the file name is updated, be sure to update the include guards. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70627/new/ https://reviews.llvm.org/D70627 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits