Eugene.Zelenko added a comment. I don't think that //misc// module should be used when checks belong to //cert//
================ Comment at: clang-tools-extra/clang-tidy/misc/SpuriouslyWakeUpFunctionsCheck.cpp:77 + const MatchFinder::MatchResult &Result) { + + const auto *MatchedWait = Result.Nodes.getNodeAs<CallExpr>("wait"); ---------------- Unnecessary empty line. ================ Comment at: clang-tools-extra/docs/ReleaseNotes.rst:97 +- New alias :doc:`cert-con36-c + <clang-tidy/checks/cert-con36-c>` to ---------------- Please move into aliases section (in alphabetical order). Same below. ================ Comment at: clang-tools-extra/docs/ReleaseNotes.rst:192 +- New :doc:`misc-spuriously-wake-up-functions + <clang-tidy/checks/misc-spuriously-wake-up-functions>` check. ---------------- Please use alphabetical order. ================ Comment at: clang-tools-extra/docs/ReleaseNotes.rst:195 + + Finds ``cnd_wait`` or ``wait`` function calls when the function is not + invoked from a loop that checks whether a condition predicate holds or the ---------------- Please synchronize with first statement in documentation. ================ Comment at: clang-tools-extra/test/clang-tidy/misc-spuriously-wake-up-functions.cpp:1 +// RUN: %check_clang_tidy %s misc-spuriously-wake-up-functions %t -- -- -I %S/../../../libcxx/include/ + ---------------- What will happen if libcxx is not part build/source tree? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70876/new/ https://reviews.llvm.org/D70876 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits