michele.scandale added inline comments.
================ Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2345 + << "-ffp-contract=fast"; + optID = options::OPT_ffp_contract; + FPModel = Val; ---------------- mibintc wrote: > michele.scandale wrote: > > Here the state of the floating point options seems unchanged except for > > `FPContract`. If I run `clang -ffp-model=fast -ffp-model=precise`, I would > > expect the state of the floating point options to match the one of > > `-fno-fast-math` except for `FPContract` which you want to be set to "fast". > > > > I think you might need to replicate the reset for all the option here as > > well, so at this point I don't know how much worth is to use the optID > > reset trick for the "fast" case only. > @michele.scandale Thanks for your helpful review, I think I fixed the things > that you remarked on. I also added a test case for the assertion fail that > you saw. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62731/new/ https://reviews.llvm.org/D62731 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
