MyDeveloperDay marked an inline comment as done. MyDeveloperDay added inline comments.
================ Comment at: clang/docs/ClangFormatStyleOptions.rst:1378 +**ConstStyle** (``ConstAlignmentStyle``) + Different ways to arrange const. ---------------- aaron.ballman wrote: > MyDeveloperDay wrote: > > klimek wrote: > > > Personally, I'm somewhat against having 3 different aliases for the > > > options. I'd chose one, even though it doesn't make everybody happy, and > > > move on. I'm fine with East/West as long as the documentation makes it > > > clear what it is. > > If I have to drop the other options, I think I'd want to go with East/West > > const as I feel it has more momentum, just letting people know before I > > change the code back (to my original patch ;-) ) > > > > https://www.youtube.com/watch?v=gRmI_gsNqcI > > > > {F10954065} > > > @klimek I requested that we do not go with East/West the options and I'm > still pretty insistent on it. East/West is a kitschy way to phrase it that I > think is somewhat US-centric (where we make a pretty big distinction between > the east and west coasts). I do not want to have to mentally map left/right > to the less-clear east/west in the config file. Would you be fine if we only > had Left/Right instead of East/West? I would be fine with that option, but > figured enough people like the cute East/West designation that we might as > well support it. Just for a reference, I'm not from the US and I think east/west still translates pretty well. I was happy to support the others. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69764/new/ https://reviews.llvm.org/D69764 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
