skan marked an inline comment as done. skan added inline comments.
================ Comment at: llvm/lib/Target/X86/MCTargetDesc/X86BaseInfo.h:158 + case X86::AND16i16: + case X86::AND16mr: + case X86::AND16ri: ---------------- craig.topper wrote: > None of the AND/ADD/SUB instructions ending in mr are eligible for > macrofusion as far as I know. Those all involve a load and a store which is > not supported by macrofusion. > > We also lost all the ADD*_DB instructions from the macrofusion list. I > believe they are in the existing list incorrectly. So removing them is > correct, but as far as I can see that change was not mentioned in the > description of this patch. > > Can we split the macrofusion refactoring out of this patch so we can review > it separately and hopefully get it committed sooner than the other review > feedback. Okay, I will upload another patch to correct the macrofusion table as soon as possible. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70157/new/ https://reviews.llvm.org/D70157 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
