modocache added a comment.
This seems like a outright improvement, but as mentioned above it would be nice
to get @rsmith's take on it since I'm not an expert. Two nitpicks, though:
1. Could you please run clang-format on the lines you added/modified?
2. Could you apply these changes on top of the llvm-project monorepo? You can
do so by using the "download raw diff" link on this page, and then running `git
apply --directory=clang -p 0 D70219.diff` from within the monorepo. I tried
just now to confirm the tests pass with this change (they do!), and that
command was able to apply the patch cleanly for me.
================
Comment at: lib/Frontend/FrontendAction.cpp:568
+ ASTDiags, CI.getFileSystemOpts(), CI.getCodeGenOpts().DebugTypeExtRefs,
+ false, None, CaptureDiagsKind::None, false, false,
CI.getHeaderSearchOpts().PrebuiltModuleFiles);
if (!AST)
----------------
For example I think this line would change if clang-format were to be run on it.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70219/new/
https://reviews.llvm.org/D70219
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
