xazax.hun added inline comments.
================ Comment at: clang/lib/Sema/SemaType.cpp:7412 + diag::warn_type_attribute_wrong_type_str) + << Attr.getAttrName()->getName() << "non-function" << CurType; + return; ---------------- aaron.ballman wrote: > You should be able to pass in `Attr` directly instead of > `Attr.getAttrName()->getName()`, I believe. Also, I'd prefer the > `non-function` be put into the diagnostic text itself with a `%select` if we > need to vary it. Indeed. But only passing Attr would result in duplicated `'`. I'm reusing the message, so I ended up not changing this part. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70469/new/ https://reviews.llvm.org/D70469 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
