a_sidorin added a comment.
Hi Gabor,
This patch looks mostly good to me. Thanks!
================
Comment at: clang/lib/AST/ASTImporter.cpp:334
+ FromDC->lookup(FromNamed->getDeclName());
+ if (std::find(FromLookup.begin(), FromLookup.end(), FromNamed) !=
+ FromLookup.end())
----------------
llvm::is_contained?
================
Comment at: clang/unittests/AST/ASTImporterTest.cpp:258
+static const RecordDecl *getRecordDeclOfFriend(FriendDecl *FD) {
+ QualType Ty = FD->getFriendType()->getType();
+ if (auto *Inner = dyn_cast<TypedefType>(Ty.getTypePtr())) {
----------------
Why don't we use getCanonicalType() anymore?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71020/new/
https://reviews.llvm.org/D71020
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
