kmclaughlin marked 2 inline comments as done.
kmclaughlin added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp:6587
+  else if (!Size)
+    Size = MemVT.getStoreSize().getKnownMinSize();
 
----------------
efriedma wrote:
> In order for alias analysis to correctly handle a MachineMemOperand, the 
> "Size" of an operation has to be conservative, in the sense that the the 
> number of bytes accessed must be at most "Size". Otherwise we'll assume two 
> operations don't alias when they actually do.
> 
> For a scaled vector, we don't know the size, so we have to conservatively 
> pass "MemoryLocation::UnknownSize".
Thanks @efriedma, I have changed this to use MemoryLocation::UnknownSize


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71000/new/

https://reviews.llvm.org/D71000



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to