tejohnson added a comment.
This LGTM, although I have a couple of questions that are orthogonal to this
patch and shouldn't block it. Please wait to see if @aaron.ballman has any more
comments.
================
Comment at: clang/test/CodeGen/libcalls-fno-builtin.c:163
-// CHECK: [[ATTR]] = { nobuiltin }
+// GLOBAL: #2 = { nobuiltin "no-builtins" }
+// INDIVIDUAL: #2 = { nobuiltin "no-builtin-ceil" "no-builtin-copysign"
"no-builtin-cos" "no-builtin-fabs" "no-builtin-floor" "no-builtin-fopen"
"no-builtin-fread" "no-builtin-fwrite" "no-builtin-stpcpy" "no-builtin-strcat"
"no-builtin-strchr" "no-builtin-strcmp" "no-builtin-strcpy" "no-builtin-strlen"
"no-builtin-strncat" "no-builtin-strncmp" "no-builtin-strncpy"
"no-builtin-strpbrk" "no-builtin-strrchr" "no-builtin-strspn"
"no-builtin-strtod" "no-builtin-strtof" "no-builtin-strtol"
"no-builtin-strtold" "no-builtin-strtoll" "no-builtin-strtoul"
"no-builtin-strtoull" }
----------------
Orthogonal to this patch:
Looks like there are 2 nobuiltin attributes now? AFAICT the old "nobuiltin"
gets applied to any and all cases where either -fno-builtin or
-fno-builtin-{name} applied. Is it obviated by the new attributes?
Also, why are the new ones quoted and the old one not?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71193/new/
https://reviews.llvm.org/D71193
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
