jdoerfert added a comment. > I applied D69853 <https://reviews.llvm.org/D69853>, D69785 > <https://reviews.llvm.org/D69785>, D69922 <https://reviews.llvm.org/D69922> > to my local build and found that D69922 <https://reviews.llvm.org/D69922> is > referring to OpenMPIRBuilder.h in llvm/Frontend whereas in D69785 > <https://reviews.llvm.org/D69785> it was introduced in > llvm/Transforms/Utils/OpenMPIRBuilder.h
I merged the first few patches. There are some I'm still waiting for the green light but the location question is now settled. ================ Comment at: clang/include/clang/Driver/Options.td:1643-1644 HelpText<"Emit OpenMP code only for SIMD-based constructs.">; +def fopenmp_enable_irbuilder : Flag<["-"], "fopenmp-enable-irbuilder">, Group<f_Group>, Flags<[CC1Option, NoArgumentUnused, HelpHidden]>, + HelpText<"Use the experimental OpenMP-IR-Builder codegen path.">; def fno_openmp_simd : Flag<["-"], "fno-openmp-simd">, Group<f_Group>, Flags<[CC1Option, NoArgumentUnused]>; ---------------- ABataev wrote: > jdoerfert wrote: > > ABataev wrote: > > > Do we need to expose this option to driver or it is enough to have just a > > > frontend option? If still need to have a driver option, add a test for > > > driver. > > How do I write a frontend option? Anything that we can query in the > > lib/CodeGen is fine with me. (I don't even need an option if we turn this > > on by default to get test coverage right away). > You nedd to move to CC1Options.td file. It means that you can't use it > direcly when invoke the drive, instead you will need to use `-Xclang > -fopenmp-...` I think people will need to use it in the short term, having it here seems therefor better. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69922/new/ https://reviews.llvm.org/D69922 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
