Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM! Thanks!
================
Comment at: clang/lib/AST/ExprConstant.cpp:7057
+
+ if (Val.isVector()) {
+ SmallVector<uint32_t, 4> Indices;
----------------
svenvh wrote:
> Anastasia wrote:
> > can Val not be vector at this point?
> Yes, for example when evaluating `const int2 fromConstexprFunc =
> addOne(int2(2));` from the included test case we get an LValue (that won't be
> folded by the code below).
I see. Would it be folded elsewhere or not folded at all?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71133/new/
https://reviews.llvm.org/D71133
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
