ABataev added a comment. In D71241#1782430 <https://reviews.llvm.org/D71241#1782430>, @JonChesterfield wrote:
> In D71241#1782427 <https://reviews.llvm.org/D71241#1782427>, @ABataev wrote: > > > In D71241#1782425 <https://reviews.llvm.org/D71241#1782425>, > > @JonChesterfield wrote: > > > > > > Explain that you're replacing the function written by the user on the > > > > fly by another one. If they accept it, go ahead. > > > > > > That's the observational effect of variants. Replacing is very similar to > > > calling + inlining. > > > > > > Not in the AST. > > > I don't see much difference between mutating the AST and mutating the SSA. > What're your objections to the former, specifically? It's not a stable > interface so tools hanging off it will have a process for updating when it > changes. https://clang.llvm.org/docs/InternalsManual.html#the-ast-library Faithfulness¶ The AST intends to provide a representation of the program that is faithful to the original source. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71241/new/ https://reviews.llvm.org/D71241 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
