cchen marked an inline comment as done. cchen added a comment. In D71475#1784284 <https://reviews.llvm.org/D71475#1784284>, @jdoerfert wrote:
> What is the output when you run the example with `k` in `lastprivate` or > `reduction`? I actually got the same result (return value) changing from firstprivate to lastprivate. Not so sure how to make linear work with reduction. > In D71475#1784173 <https://reviews.llvm.org/D71475#1784173>, @cchen wrote: > >> Doing this still fail the assertion since we still don't have the variable >> inside >> CapturedStmt. > > > So we need to mark it as captured as well. I've tried to use the `buildCapture` function before, but seems not work for me, can you point out where to look at in the source code? Thanks ================ Comment at: clang/lib/Sema/SemaOpenMP.cpp:4512 } } int ClauseKindCnt = -1; ---------------- jdoerfert wrote: > Is this "ErrorFound" here set when you run the example? ErrorFound does not set. The firstprivate node is correctly set by checking ast-dump Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71475/new/ https://reviews.llvm.org/D71475 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits