hfinkel accepted this revision.
hfinkel added a comment.
This revision is now accepted and ready to land.

In D67923#1784015 <https://reviews.llvm.org/D67923#1784015>, @tejohnson wrote:

> Please take a look. This is now updated to reflect the commit of D71193 
> <https://reviews.llvm.org/D71193>, which translated the options to the new 
> attributes. I also removed some comments that I realized didn't make sense, 
> as we need to keep a baseline availability array on the base TLII since that 
> is set based on the architecture. We simply override this for no-builtin* 
> attributes on the function. I removed the code from clang that was setting up 
> the availability array based on the options, and all tests pass.


LGTM.



================
Comment at: llvm/include/llvm/Analysis/TargetLibraryInfo.h:52
   unsigned char AvailableArray[(NumLibFuncs+3)/4];
+
   llvm::DenseMap<unsigned, std::string> CustomNames;
----------------
Unintentional new whitespace?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67923/new/

https://reviews.llvm.org/D67923



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to