ABataev added inline comments.
================ Comment at: clang/include/clang/AST/OpenMPClause.h:4918 const OMPMappableExprListSizeTy &Sizes) - : OMPMappableExprListClause(OMPC_map, Locs, Sizes, &MapperQualifierLoc, - &MapperIdInfo), + : OMPMappableExprListClause(OMPC_map, Locs, Sizes, /*HasMapper=*/true, + &MapperQualifierLoc, &MapperIdInfo), ---------------- lildmh wrote: > ABataev wrote: > > Do we really need to set `HasMapper` to `true` unconditionally here and in > > other places? > For `map`, `to`, and `from` clauses, they can have mappers, so it's set to > `true`. For `is_device_ptr` and `use_device_ptr`, it's set to `false`. So, it completely depends on the clause kind, right? If so, can we just remove it and rely on the clause kind? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67833/new/ https://reviews.llvm.org/D67833 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits