rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
Looks great to me.
This has the potential to break some existing code, though. I would suggest
either landing it early in the day, watching for breakage, and hoping for the
best, or you could try building an application that makes significant use of
Windows SDK headers to get more confidence that we won't have to revert it. You
could build the `sbox_integration_tests` target in Chrome or `chrome_elf`, and
see if that works.
================
Comment at: clang/lib/AST/ASTContext.cpp:2922
+QualType ASTContext::getFunctionTypeWithoutPtrSizes(QualType T) {
+ if (const auto *Proto = T->getAs<FunctionProtoType>()) {
----------------
Nice, this version is very simple.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71039/new/
https://reviews.llvm.org/D71039
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
