arphaman marked 2 inline comments as done. arphaman added inline comments.
================ Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:339 // Add the deployment target. - MachOTC.addMinVersionArgs(Args, CmdArgs); + if (!Version[0] || Version[0] >= 520) + MachOTC.addPlatformVersionArgs(Args, CmdArgs); ---------------- steven_wu wrote: > Why version '0' should go through the new path? Version `0` indicates that `-mlinker-version=` wasn't specified. We want to use the new flag by default. ================ Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:2530 + return "ios"; + // FIXME: Add macCatalyst support here ("\"mac catalyst\""). + llvm_unreachable("macCatalyst isn't yet supported"); ---------------- steven_wu wrote: > Why not support that in this commit? I don't see problem returning a string > with space inside. The rest of macCatalyst support is not yet upstreamed (specifically the new `Environment` value) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71579/new/ https://reviews.llvm.org/D71579 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits