kadircet marked 2 inline comments as done.
kadircet added inline comments.

================
Comment at: clang-tools-extra/clangd/unittests/HoverTests.cpp:556
+            // FIXME: Drop default arguments.
+            HI.Name = "Foo<X, int>";
+            HI.Kind = index::SymbolKind::Class;
----------------
ilya-biryukov wrote:
> NIT: Maybe remove default argument from this test for now and file a bug for 
> fixing this instead?
> Tracking this in the issue tracker seems to be better than in code.
sure filed https://github.com/clangd/clangd/issues/229


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71545/new/

https://reviews.llvm.org/D71545



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to