lebedev.ri added inline comments.
================
Comment at:
clang-tools-extra/clang-tidy/bugprone/UnsignedSubtractionCheck.cpp:21
+
+void UnsignedSubtractionCheck::registerMatchers(MatchFinder *Finder) {
+ const auto UnsignedIntType = hasType(isUnsignedInteger());
----------------
sorenj wrote:
> lebedev.ri wrote:
> > The check's name is more generic than what it does - it only looks at mixed
> > subtractions in comparisons.
> > The name implies it looks at all mixed subtractions.
> But it does look at all mixed subtractions, line 28 of the unit test shows
> one such example.
Oh, i didn't spot that one, sorry for the false alarm.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71607/new/
https://reviews.llvm.org/D71607
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
