void marked an inline comment as done. void added inline comments.
================ Comment at: clang/test/CodeGen/asm-goto.c:91 + return 1; +} ---------------- nickdesaulniers wrote: > Thanks for adding this test. I think it doesn't test that `addr` is > *clobbered* though? The `+` modifier indicates that `addr` is used for both input and output, in effect being clobbered. Otherwise, we would need to add a "clobber" list, but from what I understand that seems to be restricted to registers, memory, and `cc`. I wouldn't be able to specify a specific register for `addr` (e.g. `"+D"(addr)`) and also have `%rdx` in the clobber list. Was there something else you were thinking of? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69876/new/ https://reviews.llvm.org/D69876 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
