NoQ accepted this revision. NoQ added a comment. Woohoo tests!~~
================ Comment at: clang/unittests/Analysis/CFGBuildResult.h:69 + Finder.matchAST(AST->getASTContext()); + Callback.TheBuildResult.setAST(std::move(AST)); return std::move(Callback.TheBuildResult); ---------------- It should be slightly more visually appealing to construct the AST before the callback and pass it into the constructor of the callback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71791/new/ https://reviews.llvm.org/D71791 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
