derek added a comment. Herald added a subscriber: mgehre. @zinovy.nis @alexfh @JonasToth @MyDeveloperDay
Hi folks, please correct me if I'm wrong but it appears that an effect of this change is that this script will no longer exit non-zero if `clang-tidy` discovers any errors, which was the previous functionality with `sys.exit(subprocess.call(' '.join(command), shell=True))`. As a result, when we upgraded a project to LLVM 9 our CI began having false-positives, as we relied on the exit code of this script to indicate success/failure. Would it be possible to restore that functionality? I'd be happy to provide a patch. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57662/new/ https://reviews.llvm.org/D57662 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits