njames93 added a comment. In D71846#1800481 <https://reviews.llvm.org/D71846#1800481>, @aaron.ballman wrote:
> In D71846#1800480 <https://reviews.llvm.org/D71846#1800480>, @njames93 wrote: > > > Definitely default to diagnosing everything, that's how my current > > implementation looks right now. > > > SGTM > > > Also is there a way to do options as bool because I don't particularly like > > putting 1 for true in the config file > > Not to my knowledge. I just did a quick grep and found that all checks that take bools for config options use a 1 for true, 0 for false, so I guess best stick to convention rather than hack at OptionsView to get and set bools CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71846/new/ https://reviews.llvm.org/D71846 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
