dmajor added a comment. Thanks for doing this!
When I applied this patch and added `__declspec(guard(nocf))` to the function that was giving us trouble <https://searchfox.org/mozilla-central/rev/652014ca1183c56bc5f04daf01af180d4e50a91c/mozglue/misc/nsWindowsDllInterceptor.h#139>, I still crashed with a CFG failure in the caller, since the `nocf` function was inlined. When I additionally marked that function as `noinline`, then the CFG checks were omitted, as desired. Is this behavior with respect to inlining expected? You may want to mention "PR44096" in the commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72167/new/ https://reviews.llvm.org/D72167 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
