logan-5 added inline comments.
================ Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-reserved-identifier-invert.cpp:21 +// CHECK-MESSAGES: :[[@LINE-1]]:8: warning: declaration uses identifier 'Helper', which is not a reserved identifier [bugprone-reserved-identifier] +// CHECK-FIXES: {{^}}struct __Helper {};{{$}} +struct _helper2 {}; ---------------- Mordante wrote: > Why suggesting `__Helper` instead of `_Helper` ? I mostly didn't see a reason to make the check opinionated on //how// to uglify names, though I suppose now that you mention it, a smaller change to the name when possible is arguably better. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72213/new/ https://reviews.llvm.org/D72213 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits